Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove double quotes, looks like it is passing as a single string to cosign and not as an array #2205

Merged
merged 1 commit into from Aug 30, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 29, 2022

Summary

  • ko now output more digests (before 0.11.2 release the output was just one) and that was passing as a unique big string to cosign failing the job

ran the fix here: https://github.com/cpanato/cosign/actions/runs/2950002823

@cpanato cpanato requested a review from dlorenc August 29, 2022 16:25
…osign and not as an array

Signed-off-by: cpanato <ctadeu@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #2205 (8b05d40) into main (31e6654) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8b05d40 differs from pull request most recent head cf41f1a. Consider uploading reports for the commit cf41f1a to get more accurate results

@@            Coverage Diff             @@
##             main    #2205      +/-   ##
==========================================
- Coverage   26.51%   26.51%   -0.01%     
==========================================
  Files         131      131              
  Lines        7670     7671       +1     
==========================================
  Hits         2034     2034              
- Misses       5375     5376       +1     
  Partials      261      261              
Impacted Files Coverage Δ
cmd/cosign/cli/options/registry.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlorenc dlorenc merged commit 5c50944 into sigstore:main Aug 30, 2022
@github-actions github-actions bot added this to the v1.12.0 milestone Aug 30, 2022
@cpanato cpanato deleted the fix branch August 30, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants