Support non-ECDSA key types for verify-blob #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleans up some code in the CT log verification to use the Sigstore function that handles multiple PEM formats. It removes DER encoding support, but that should not have been used. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov Report
@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
- Coverage 26.69% 26.51% -0.18%
==========================================
Files 131 131
Lines 7690 7670 -20
==========================================
- Hits 2053 2034 -19
+ Misses 5376 5375 -1
Partials 261 261
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
priyawadhwa
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleans up some code in the CT log verification to use the Sigstore
function that handles multiple PEM formats. It removes DER encoding
support, but that should not have been used.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Release Note
Documentation