Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update e2e job to run only when push to main #2169

Merged
merged 1 commit into from Aug 16, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 16, 2022

Summary

  • update e2e job to run only when push to main

to avoid run jobs when pushing to the upstream, like dependabot

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Aug 16, 2022

example: #2167

@dlorenc
Copy link
Member

dlorenc commented Aug 16, 2022

Just to confirm, this will let us run tests on other branches via a workflow_dispatch?

@cpanato
Copy link
Member Author

cpanato commented Aug 16, 2022

Just to confirm, this will let us run tests on other branches via a workflow_dispatch?

yes we can do that

Screenshot 2022-08-16 at 18 53 39

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #2169 (f72c280) into main (026523a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2169   +/-   ##
=======================================
  Coverage   26.26%   26.26%           
=======================================
  Files         130      130           
  Lines        7615     7614    -1     
=======================================
  Hits         2000     2000           
+ Misses       5359     5358    -1     
  Partials      256      256           
Impacted Files Coverage Δ
cmd/cosign/cli/fulcio/fulcio.go 18.26% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlorenc
Copy link
Member

dlorenc commented Aug 16, 2022

Awesome, sounds great!

@dlorenc dlorenc enabled auto-merge (squash) August 16, 2022 16:56
@dlorenc dlorenc merged commit c504f45 into sigstore:main Aug 16, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Aug 16, 2022
@cpanato cpanato deleted the update-job branch August 16, 2022 17:57
cldmnky pushed a commit to cldmnky/cosign that referenced this pull request Aug 21, 2022
Signed-off-by: cpanato <ctadeu@gmail.com>

Signed-off-by: cpanato <ctadeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants