Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TUF from scaffolding for validating cosign. #2146

Merged
merged 5 commits into from Aug 10, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Aug 10, 2022

Now that scaffolding supports TUF, add tests with it for cosign. Previously these were done with various env variables, now use cosign initialize to use the TUF root.

@asraa

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Summary

Release Note

Documentation

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
hectorj2f
hectorj2f previously approved these changes Aug 10, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #2146 (54be3ae) into main (72c4224) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2146   +/-   ##
=======================================
  Coverage   26.23%   26.23%           
=======================================
  Files         130      130           
  Lines        7617     7617           
=======================================
  Hits         1998     1998           
  Misses       5362     5362           
  Partials      257      257           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vaikas
Copy link
Contributor Author

vaikas commented Aug 10, 2022

Hm, I don't see the verify-attestation test running, did it maybe get turned off during yesterdays breakage (I'm sorry about that :( )

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Copy link
Contributor Author

vaikas commented Aug 10, 2022

I just had screwed up the 4 lines of yaml (couple of times).

Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vaikas vaikas merged commit 425bd10 into sigstore:main Aug 10, 2022
@vaikas vaikas deleted the new-scaffolding-with-tuf branch August 10, 2022 14:16
@github-actions github-actions bot added this to the v1.11.0 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants