Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to clarify registry use. #2145

Merged
merged 1 commit into from Aug 9, 2022
Merged

Add notes to clarify registry use. #2145

merged 1 commit into from Aug 9, 2022

Conversation

bendory
Copy link
Contributor

@bendory bendory commented Aug 9, 2022

Closes #2144

Summary

Motivation: I tried to use Artifact Registry and was surprised that specifying the repository as described did not work. I intend to highlight this to the Artifact Registry team, but for now I am documenting it here so that other users don't stumble as I did.

Release Note

NONE

Documentation

Documented.

Signed-off-by: David Bendory <bendory@google.com>
@dlorenc
Copy link
Member

dlorenc commented Aug 9, 2022

cc @jonjohnsonjr

@codecov-commenter
Copy link

Codecov Report

Merging #2145 (a01fe88) into main (7a334aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2145   +/-   ##
=======================================
  Coverage   26.28%   26.28%           
=======================================
  Files         130      130           
  Lines        7602     7602           
=======================================
  Hits         1998     1998           
  Misses       5347     5347           
  Partials      257      257           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dlorenc
Copy link
Member

dlorenc commented Aug 9, 2022

The failure is unrelated and the fix is being tracked here: sigstore/scaffolding#277

No need to wait on the merge.

@dlorenc dlorenc merged commit 72c4224 into sigstore:main Aug 9, 2022
@github-actions github-actions bot added this to the v1.11.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify documentation around registry spec
3 participants