Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warning for sget CLI and packages #2019

Merged
merged 2 commits into from Sep 6, 2022

Conversation

imjasonh
Copy link
Member

Signed-off-by: Jason Hall jason@chainguard.dev

@dlorenc @lukehinds

Release Note

The sget tool in the cosign repo is deprecated and will be removed in a future release -- see https://github.com/sigstore/sget for the new tool.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #2019 (cbdb114) into main (4e282fd) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
- Coverage   26.15%   26.13%   -0.03%     
==========================================
  Files         127      127              
  Lines        7425     7432       +7     
==========================================
  Hits         1942     1942              
- Misses       5228     5235       +7     
  Partials      255      255              
Impacted Files Coverage Δ
cmd/cosign/cli/policy_init.go 1.38% <ø> (-0.01%) ⬇️
pkg/cosign/keys.go 61.36% <0.00%> (ø)
pkg/cosign/common.go 0.00% <0.00%> (ø)
cmd/cosign/cli/sign.go 0.00% <0.00%> (ø)
cmd/cosign/cli/clean.go 0.00% <0.00%> (ø)
cmd/cosign/cli/attest.go 0.00% <0.00%> (ø)
cmd/cosign/cli/commands.go 0.00% <0.00%> (ø)
cmd/cosign/cli/signblob.go 0.00% <0.00%> (ø)
pkg/cosign/rekor_factory.go 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e282fd...cbdb114. Read the comment docs.

cpanato
cpanato previously approved these changes Aug 3, 2022
hectorj2f
hectorj2f previously approved these changes Aug 3, 2022
bobcallaway
bobcallaway previously approved these changes Aug 3, 2022
@imjasonh
Copy link
Member Author

Is this good to merge? 🙏

@imjasonh imjasonh mentioned this pull request Sep 6, 2022
@cpanato cpanato enabled auto-merge (squash) September 6, 2022 13:55
Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Jason Hall <jason@chainguard.dev>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rebased to get this merged

@cpanato cpanato merged commit 1f42a24 into sigstore:main Sep 6, 2022
@github-actions github-actions bot added this to the v1.12.0 milestone Sep 6, 2022
chaospuppy pushed a commit to chaospuppy/cosign that referenced this pull request Sep 7, 2022
* Add deprecation warning for sget CLI and packages

Signed-off-by: Jason Hall <jason@chainguard.dev>

* ignore deprecations we're adding

Signed-off-by: Jason Hall <jason@chainguard.dev>

Signed-off-by: Jason Hall <jason@chainguard.dev>
Signed-off-by: Tim Seagren <seagren.tim@solute.us>
LeSuisse added a commit to LeSuisse/nixpkgs that referenced this pull request Oct 8, 2022
This binary was provided by the `cosign` package until now but it is in
the process of being removed, see sigstore/cosign#2019

Since it might be removed during the 22.11 cycle we drop it
preventively. This will make possible security backports easier if we
need them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants