Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta1 API for cosigned #1890

Merged
merged 7 commits into from May 18, 2022
Merged

v1beta1 API for cosigned #1890

merged 7 commits into from May 18, 2022

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented May 17, 2022

Summary

Add v1beta1 API for cosigned.

Ticket Link

Fixes #1835

-->
Fixes

Release Note

Add v1beta1 API for cosigned

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vaikas It seems we are missing the new CRD version in config/300-clusterimagepolicy.yaml

@vaikas
Copy link
Contributor Author

vaikas commented May 17, 2022

@hectorj2f yeah, I need to figure out how to do this safely with the codegen :)

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas
Copy link
Contributor Author

vaikas commented May 17, 2022

I'm looking at the test failures, but it seems to not be able to get the latest release tag for scaffolding:

++ curl -s -u username:*** https://api.github.com/repos/sigstore/scaffolding/releases/latest
+ tag=null
+ echo 'Installing kind and knative using release'
+ curl -Lo ./setup-kind.sh https://github.com/sigstore/scaffolding/releases/download/null/setup-kind.sh

Notice the tag is null

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #1890 (6c6dee6) into main (5d87c9d) will increase coverage by 0.67%.
The diff coverage is 44.61%.

@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
+ Coverage   33.35%   34.02%   +0.67%     
==========================================
  Files         146      153       +7     
  Lines        9370     9936     +566     
==========================================
+ Hits         3125     3381     +256     
- Misses       5874     6175     +301     
- Partials      371      380       +9     
Impacted Files Coverage Δ
cmd/cosign/policy_webhook/main.go 0.00% <0.00%> (ø)
...apis/cosigned/v1alpha1/clusterimagepolicy_types.go 0.00% <ø> (ø)
.../apis/cosigned/v1beta1/clusterimagepolicy_types.go 0.00% <0.00%> (ø)
pkg/apis/cosigned/v1beta1/register.go 0.00% <0.00%> (ø)
pkg/apis/cosigned/v1beta1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
...cosigned/v1alpha1/clusterimagepolicy_conversion.go 79.41% <79.41%> (ø)
.../cosigned/v1beta1/clusterimagepolicy_validation.go 93.83% <93.83%> (ø)
...cosigned/v1alpha1/clusterimagepolicy_validation.go 93.75% <100.00%> (-0.09%) ⬇️
.../cosigned/v1beta1/clusterimagepolicy_conversion.go 100.00% <100.00%> (ø)
...is/cosigned/v1beta1/clusterimagepolicy_defaults.go 100.00% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d87c9d...6c6dee6. Read the comment docs.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks good to me. We can add the e2e tests in a different PR.

@hectorj2f hectorj2f added the enhancement New feature or request label May 18, 2022
@dlorenc dlorenc merged commit 1afff48 into sigstore:main May 18, 2022
@github-actions github-actions bot added this to the v1.9.0 milestone May 18, 2022
@hectorj2f
Copy link
Contributor

thanks @dlorenc :)

@vaikas vaikas deleted the v1beta1 branch May 23, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cosigned] Bump API version to v1beta1
5 participants