Remove dependency on deprecated github.com/pkg/errors

[zchee]

Summary

Remove dependency on deprecated github.com/pkg/errors.

Ticket Link

Update: #1880

Release Note

???

[zchee]

cc: @imjasonh I started cleanup pkg/errors dependency, but still draft.

[zchee]

This pull request is a huge change. Therefore, split the commit by the package one by one, as another contributor's PR may conflict with the main branch after merging this pull request.
I'll do squash last time if need squash in terms of commit messages.

[zchee]

@imjasonh Great, let's remove deprecated packages from the Go community world :P (I think it will be long-term lol

[zchee]

@imjasonh
I wrote this change by hand this time and it was very annoying lol
I'll write an analyzer that rewrites source code using "x/tools/go/analysis" and send a pull request to fulcio and rekor, with it. It would be useful in other projects as well.

---

Well, PTAL.

[imjasonh]

I'll write an analyzer that rewrites source code using "x/tools/go/analysis" and send a pull request to fulcio and rekor, with it. It would be useful in other projects as well.

Oh please oh please oh please. If you do this I will be forever in your debt. 🙏

[imjasonh]

https://github.com/sigstore/cosign/runs/6458613293?check_suite_focus=true#step:12:286 looks like a bad %w usage.

I've noticed when doing this in other repos that sometimes you'll have a errors.Wrapf("hello", someString) (without a %s), which nothing complains about. But then when you change it to fmt.Errorf things notice the missing placeholder and complain, or fail, or have bad output. It's good to find them, but it's one more annoying thing to have to look for.

[zchee]

@imjasonh Ah, mistake, will fix asap.

It's good to find them, but it's one more annoying thing to have to look for.

Yeah, it seems to pkg/errors bug(?), I'm surprised.

Oh please oh please oh please. If you do this I will be forever in your debt. 🙏

lol, will do.

[zchee]

will fix too.

[zchee]

@imjasonh

sigstore/cosign/runs/6458613293?check_suite_focus=true#step:12:286 looks like a bad %w usage.

I've noticed when doing this in other repos that sometimes you'll have a errors.Wrapf("hello", someString) (without a %s), which nothing complains about. But then when you change it to fmt.Errorf things notice the missing placeholder and complain, or fail, or have bad output. It's good to find them, but it's one more annoying thing to have to look for.

I found the root cause that GetEnvTargetRepository did not handle error until now. Fixed on 80ab7ef (#1887). PTALA.

[codecov-commenter]

Codecov Report

Merging #1887 (80ab7ef) into main (8b7017d) will increase coverage by 0.01%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main    #1887      +/-   ##
==========================================
+ Coverage   33.35%   33.36%   +0.01%     
==========================================
  Files         146      146              
  Lines        9370     9372       +2     
==========================================
+ Hits         3125     3127       +2     
  Misses       5874     5874              
  Partials      371      371              

Impacted Files	Coverage Δ
cmd/cosign/cli/attest.go	0.00% <0.00%> (ø)
cmd/cosign/cli/commands.go	0.00% <0.00%> (ø)
cmd/cosign/cli/dockerfile/verify.go	41.66% <ø> (ø)
cmd/cosign/cli/fulcio/fulcio.go	21.42% <0.00%> (ø)
cmd/cosign/cli/fulcio/fulcioroots/fulcioroots.go	36.36% <0.00%> (ø)
cmd/cosign/cli/generate/generate_key_pair.go	9.21% <0.00%> (ø)
cmd/cosign/cli/load.go	0.00% <0.00%> (ø)
cmd/cosign/cli/manifest/verify.go	47.69% <0.00%> (ø)
cmd/cosign/cli/options/oidc.go	0.00% <0.00%> (ø)
cmd/cosign/cli/policy_init.go	1.40% <0.00%> (ø)
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7017d...80ab7ef. Read the comment docs.

[zchee]

@imjasonh @dlorenc @cpanato thanks! I'll fix rekor and fulcio too.