tree: only report artifacts that are present #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were adding entries for artifacts, regardless of whether that artifact was present or had any layers. I think the expectation of the user would be for this command to show only the artifacts that actually exist. Signed-off-by: Rob Best <robertbest89@gmail.com>
We're already fetching the references and using them in the map, so might as well check those when we come to print them out. Use the SBOM suffix from ociremote rather than redefining it. Signed-off-by: Rob Best <robertbest89@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1872 +/- ##
==========================================
+ Coverage 33.37% 33.38% +0.01%
==========================================
Files 146 146
Lines 9378 9375 -3
==========================================
Hits 3130 3130
+ Misses 5875 5872 -3
Partials 373 373
Continue to review full report at Codecov.
|
|
Both CI failures seem unrelated to the changes in this PR. |
hectorj2f
approved these changes
May 13, 2022
|
It seems there are some linting issues. |
@hectorj2f Looks like a timeout issue. When I run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Only returns artifacts in the tree if they actually exist. I think this matches the expectations a user would have when using this command.
Also tweaks how we're using the references:
ociremotepackage rather than redefining it in cliTicket Link
N/A
Release Note