Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sget: Enable KMS providers for sget #1852

Merged
merged 1 commit into from May 7, 2022
Merged

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented May 6, 2022

After sigstore/sigstore#276 cosign/sget wasn't set up to initialize all the supported KMS providers.

Release Note

Enable supported KMS providers for sget

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #1852 (a1c9427) into main (1258512) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   33.44%   33.41%   -0.04%     
==========================================
  Files         146      146              
  Lines        9340     9340              
==========================================
- Hits         3124     3121       -3     
- Misses       5843     5845       +2     
- Partials      373      374       +1     
Impacted Files Coverage Δ
pkg/cosign/tuf/client.go 61.68% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1258512...a1c9427. Read the comment docs.

@dlorenc
Copy link
Member

dlorenc commented May 7, 2022

DCO!

cpanato
cpanato previously approved these changes May 7, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dco party!

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh
Copy link
Member Author

imjasonh commented May 7, 2022

DCO!

I dislike DCO very much!

(Fixed)

@dlorenc dlorenc merged commit 8793c0f into sigstore:main May 7, 2022
@github-actions github-actions bot added this to the v1.9.0 milestone May 7, 2022
pxp928 pushed a commit to pxp928/cosign that referenced this pull request May 12, 2022
Signed-off-by: Jason Hall <jason@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants