Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix piv-tool generate-key command in TOKENS doc #1850

Merged
merged 1 commit into from May 7, 2022

Commits on May 7, 2022

  1. Fix piv-tool generate-key command in TOKENS doc

    [cosign/TOKENS\.md at main · sigstore/cosign](https://github.com/sigstore/cosign/blob/main/TOKENS.md) says:
    
    ... *run the* `cosign generate-key` *command* ...
    
    Which yields this error:
    
    ```
    $ cosign generate-key
    Error: unknown command "generate-key" for "cosign"
    ```
    
    The documentation is simply missing the `piv-tool` sub-command.
    
    Resolves: sigstore#1849
    
    Also fix make target for custom build: was make cosign-pivkey
    now make cosign-pivkey-pkcs11key.
    Drop old, brittle reference to line in Makefile.
    
    Also make `go build` also work the same way, from the root directory.
    
    See also: sigstore#1853
    
    Signed-off-by: Neal McBurnett <neal@mcburnett.org>
    nealmcb committed May 7, 2022
    Configuration menu
    Copy the full SHA
    76b7071 View commit details
    Browse the repository at this point in the history