Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go.mod exclude line #1836

Closed
wants to merge 1 commit into from
Closed

Conversation

puiterwijk
Copy link

@puiterwijk puiterwijk commented May 4, 2022

This line got added in PR #1731 (commit
920dcfa), and breaks go install
github.com/sigstore/cosign/cmd/cosign.

Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org

This line got added in PR#1731 (commit
920dcfa), and breaks go install
github.com/sigstore/cosign/cmd/cosign.

Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
@cpanato
Copy link
Member

cpanato commented May 4, 2022

@haydentherapper you added that, do you know the reason for that?

@puiterwijk
Copy link
Author

For info, the message that results, on both Go 1.16 and go 1.18:

[root@913ff300c5c8 /]# go install -v github.com/sigstore/cosign/cmd/cosign@latest
go: downloading github.com/sigstore/cosign v1.8.0
go: github.com/sigstore/cosign/cmd/cosign@latest (in github.com/sigstore/cosign@v1.8.0):
	The go.mod file for the module providing named packages contains one or
	more exclude directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

@puiterwijk
Copy link
Author

(Also, I could not find any information in the PR as to why it was added nor that it was even brought up during reviews.)

@haydentherapper
Copy link
Contributor

This was to avoid pulling in a dependency that declared the same flag names. However I think I fixed it in another way? Tests will need to pass with this removed to confirm that.

@cpanato
Copy link
Member

cpanato commented May 4, 2022

@puiterwijk you need to run go mod tidy and after you should run ./hack/update-codegen.sh and then commit the changes

@cpanato
Copy link
Member

cpanato commented May 7, 2022

fixed here #1846
closing this one
thanks for your PR!

@cpanato cpanato closed this May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants