New flag --oidc-providers-disable to disable OIDC providers #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorj2f
reviewed
May 2, 2022
cmd/cosign/cli/options/oidc.go
Outdated
| @@ -66,4 +67,7 @@ func (o *OIDCOptions) AddFlags(cmd *cobra.Command) { | |||
|
|
|||
| cmd.Flags().StringVar(&o.RedirectURL, "oidc-redirect-url", "", | |||
| "[EXPERIMENTAL] OIDC redirect URL (Optional). The default oidc-redirect-url is 'http://localhost:0/auth/callback'.") | |||
|
|
|||
| cmd.Flags().BoolVar(&o.DisableAmbientProviders, "oidc-providers-disable", false, | |||
There was a problem hiding this comment.
I believe the cli documentation is missing.
There was a problem hiding this comment.
Thanks hector! I just regenerated them.
puerco
force-pushed
the
disable-oidc-providers
branch
from
4cdaece
to
99c1db0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1832 +/- ##
==========================================
- Coverage 33.01% 32.99% -0.02%
==========================================
Files 147 147
Lines 9350 9355 +5
==========================================
Hits 3087 3087
- Misses 5909 5914 +5
Partials 354 354
Continue to review full report at Codecov.
|
puerco
force-pushed
the
disable-oidc-providers
branch
from
99c1db0
to
1323866
Compare
woodruffw
reviewed
May 2, 2022
cmd/cosign/cli/options/oidc.go
Outdated
| @@ -66,4 +67,7 @@ func (o *OIDCOptions) AddFlags(cmd *cobra.Command) { | |||
|
|
|||
| cmd.Flags().StringVar(&o.RedirectURL, "oidc-redirect-url", "", | |||
| "[EXPERIMENTAL] OIDC redirect URL (Optional). The default oidc-redirect-url is 'http://localhost:0/auth/callback'.") | |||
|
|
|||
| cmd.Flags().BoolVar(&o.DisableAmbientProviders, "oidc-providers-disable", false, | |||
There was a problem hiding this comment.
This is yakshaving, but IMO the --oidc-providers-disable flag could be a little more descriptive.
In sigstore-python we refer to these providers as "ambient" providers to distinguish them from explicit OAuth flows and other sources of identities. I think a flag name like --disable-ambient-oidc or similar (--oidc-disable-ambient-providers, etc.) would better capture the semantics here.
There was a problem hiding this comment.
Sounds good to me, thanks for the suggestion @woodruffw , changed.
This commit adds an option to tell the fulcio client to avoid trying to get an auth token from the internal OIDC providers. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
puerco
force-pushed
the
disable-oidc-providers
branch
from
1323866
to
8ade296
Compare
…oviders This commit adds a command line flag `--oidc-providers-disable` to `cosign sign` and `cosign sign-blob` to disable the internal OIDC providers. This does not break compatibility with the current cli and skips the providers logic to jump straight to the OIDC flow. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
puerco
force-pushed
the
disable-oidc-providers
branch
4 times, most recently
from
2346074
to
a440205
Compare
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
puerco
force-pushed
the
disable-oidc-providers
branch
from
a440205
to
4f5ed66
Compare
hectorj2f
approved these changes
May 2, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…#1832) * Add KeyOpt to disable internal providers This commit adds an option to tell the fulcio client to avoid trying to get an auth token from the internal OIDC providers. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev> * Add --oidc-disable-ambient-providers flag to disable internal OIDC providers This commit adds a command line flag `--oidc-providers-disable` to `cosign sign` and `cosign sign-blob` to disable the internal OIDC providers. This does not break compatibility with the current cli and skips the providers logic to jump straight to the OIDC flow. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev> * Update internal docs for new OIDC flag Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new command line flag
--oidc-providers-disabletocosign signandcosign sign-blobto disable the internal OIDC providers. This does not break compatibility with the current cli and skips the providers logic to jump straight to the OIDC flow./cc @di @eddiezane
Signed-off-by: Adolfo García Veytia (Puerco) puerco@chainguard.dev
Ticket Link
Fixes #1819
Release Note