cosigned: Test unsupported KMS providers #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
force-pushed
the
kms-init
branch
2 times, most recently
from
ea3c570
to
04aa0b0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1820 +/- ##
==========================================
+ Coverage 32.95% 33.02% +0.06%
==========================================
Files 147 147
Lines 9348 9347 -1
==========================================
+ Hits 3081 3087 +6
+ Misses 5911 5906 -5
+ Partials 356 354 -2
Continue to review full report at Codecov.
|
This adds a test case to cover the case where a specified KMS provider isn't supported; in this case, we fire an event describing the error. Signed-off-by: Jason Hall <jason@chainguard.dev>
dlorenc
approved these changes
Apr 30, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
This adds a test case to cover the case where a specified KMS provider isn't supported; in this case, we fire an event describing the error. Signed-off-by: Jason Hall <jason@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case to cover the case where a specified KMS provider
isn't supported; in this case, we fire an event describing the error.
Signed-off-by: Jason Hall jason@chainguard.dev
cc @mattmoor