Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rego policy support #1817

Merged
merged 2 commits into from Apr 29, 2022
Merged

Conversation

hectorj2f
Copy link
Contributor

@hectorj2f hectorj2f commented Apr 29, 2022

Signed-off-by: hectorj2f hectorf@vmware.com

Summary

Add support to evaluate policies using rego language.

Ticket Link

Fixes #1772

Release Note

cosigned: add support to evaluate rego policies

@hectorj2f hectorj2f added the enhancement New feature or request label Apr 29, 2022
@hectorj2f hectorj2f requested a review from vaikas April 29, 2022 15:14
@hectorj2f hectorj2f self-assigned this Apr 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #1817 (52c3f24) into main (4f02c2d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 52c3f24 differs from pull request most recent head 7da9cb2. Consider uploading reports for the commit 7da9cb2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
+ Coverage   32.85%   32.96%   +0.11%     
==========================================
  Files         147      147              
  Lines        9346     9345       -1     
==========================================
+ Hits         3071     3081      +10     
+ Misses       5919     5908      -11     
  Partials      356      356              
Impacted Files Coverage Δ
pkg/policy/eval.go 79.48% <100.00%> (+26.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f02c2d...7da9cb2. Read the comment docs.

Signed-off-by: hectorj2f <hectorf@vmware.com>
Signed-off-by: hectorj2f <hectorf@vmware.com>
Copy link
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@vaikas vaikas merged commit 9595922 into sigstore:main Apr 29, 2022
@github-actions github-actions bot added this to the v1.9.0 milestone Apr 29, 2022
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
* feat: add rego policy support

Signed-off-by: hectorj2f <hectorf@vmware.com>

* chore: add nolint to error msg

Signed-off-by: hectorj2f <hectorf@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants