Support PKCS1 encoded and non-ECDSA CT log public keys #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up while testing out staging, which uses a PKCS1 encoded public key. We should be flexible on the supported key format. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
cc @dlorenc - If 1.8 hasn't gone out yet, getting this in too would be nice! |
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
dlorenc
previously approved these changes
Apr 26, 2022
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
@dlorenc - pushed another commit that removes the requirement that the key is an ECDSA key - I don't see any reason this should be enforced. |
Codecov Report
@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 32.73% 32.75% +0.01%
==========================================
Files 147 147
Lines 9313 9327 +14
==========================================
+ Hits 3049 3055 +6
- Misses 5907 5915 +8
Partials 357 357
Continue to review full report at Codecov.
|
haydentherapper
changed the title
dlorenc
approved these changes
Apr 26, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
* Support PKCS1 encoded CT log public keys This came up while testing out staging, which uses a PKCS1 encoded public key. We should be flexible on the supported key format. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Update comment Signed-off-by: Hayden Blauzvern <hblauzvern@google.com> * Remove requirement that key is ECDSA Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up while testing out staging, which uses a PKCS1 encoded
public key. We should be flexible on the supported key format.
This also relaxes the requirement that CT log keys from TUF are ECDSA keys.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note