Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cue unit tests #1791

Merged
merged 1 commit into from Apr 23, 2022
Merged

Conversation

hectorj2f
Copy link
Contributor

Signed-off-by: hectorj2f hectorf@vmware.com

Summary

We didn't have unit tests for cue. This PR adds some tests to validate cue syntax for the current code and add examples of advanced policy verifications.

Ticket Link

Fixes

Release Note

test: add cue unit tests

Signed-off-by: hectorj2f <hectorf@vmware.com>
@hectorj2f hectorj2f added the enhancement New feature or request label Apr 22, 2022
@hectorj2f hectorj2f self-assigned this Apr 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #1791 (212a990) into main (8368bad) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
+ Coverage   31.45%   31.48%   +0.02%     
==========================================
  Files         144      145       +1     
  Lines        8896     8913      +17     
==========================================
+ Hits         2798     2806       +8     
- Misses       5761     5767       +6     
- Partials      337      340       +3     
Impacted Files Coverage Δ
pkg/cosign/tuf/client.go 61.68% <0.00%> (-0.82%) ⬇️
pkg/cosign/cue/cue.go 64.70% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8368bad...212a990. Read the comment docs.

@dlorenc dlorenc merged commit c96ebb4 into sigstore:main Apr 23, 2022
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 23, 2022
@hectorj2f hectorj2f deleted the add_cue_unit_tests branch April 23, 2022 17:55
mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: hectorj2f <hectorf@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants