Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosigned: add support for rsa keys #1768

Merged
merged 1 commit into from Apr 17, 2022

Conversation

hectorj2f
Copy link
Contributor

Signed-off-by: hectorj2f hectorf@vmware.com

Summary

Similarly to cosign, this PR adds support for RSA keys.

Ticket Link

Fixes #1729

Release Note

cosigned: add support for RSA keys

Signed-off-by: hectorj2f <hectorf@vmware.com>
@hectorj2f hectorj2f added the bug Something isn't working label Apr 17, 2022
@hectorj2f hectorj2f self-assigned this Apr 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #1768 (c368027) into main (f2c360e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1768   +/-   ##
=======================================
  Coverage   31.39%   31.39%           
=======================================
  Files         144      144           
  Lines        8879     8879           
=======================================
  Hits         2788     2788           
  Misses       5755     5755           
  Partials      336      336           
Impacted Files Coverage Δ
pkg/cosign/kubernetes/webhook/validation.go 83.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c360e...c368027. Read the comment docs.

@dlorenc dlorenc merged commit 546ca56 into sigstore:main Apr 17, 2022
@github-actions github-actions bot added this to the v1.8.0 milestone Apr 17, 2022
@hectorj2f hectorj2f deleted the cosigned_support_rsa branch April 17, 2022 22:29
@hectorj2f
Copy link
Contributor Author

Thanks for the review @dlorenc

mlieberman85 pushed a commit to mlieberman85/cosign that referenced this pull request May 6, 2022
Signed-off-by: hectorj2f <hectorf@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cosigned] Webhook error when trying to verify an image signed with RSA key
3 participants