Use bundle log ID to find verification key #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of iterating over all log verification keys, we use the log ID in the bundle to find the correct key. This avoids iterating over all trusted keys. Note that the log ID is not signed. If the offline bundle is manipulated so that the log ID does not resolve to a valid key, this will not result in a denial of service attack, because cosign will fall back to fetching the entry from the online log. The equivalent change for CT entry verification has been made in another PR. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
cc @asraa |
dlorenc
approved these changes
Apr 12, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Instead of iterating over all log verification keys, we use the log ID in the bundle to find the correct key. This avoids iterating over all trusted keys. Note that the log ID is not signed. If the offline bundle is manipulated so that the log ID does not resolve to a valid key, this will not result in a denial of service attack, because cosign will fall back to fetching the entry from the online log. The equivalent change for CT entry verification has been made in another PR. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of iterating over all log verification keys, we use the log ID
in the bundle to find the correct key. This avoids iterating over all
trusted keys.
Note that the log ID is not signed. If the offline bundle is manipulated
so that the log ID does not resolve to a valid key, this will not result
in a denial of service attack, because cosign will fall back to fetching
the entry from the online log.
The equivalent change for CT entry verification has been made in another
PR.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note