Refactor policy related code, add support for vuln verify #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
hectorj2f
reviewed
Apr 12, 2022
| @@ -122,7 +121,7 @@ func (c *VerifyAttestationCommand) Exec(ctx context.Context, images []string) (e | |||
| return errors.Wrap(err, "loading certificate from reference") | |||
| } | |||
| if c.CertChain == "" { | |||
| co.SigVerifier, err = signature.LoadVerifier(cert.PublicKey, crypto.SHA256) | |||
| co.SigVerifier, err = signature.LoadECDSAVerifier(cert.PublicKey.(*ecdsa.PublicKey), crypto.SHA256) | |||
There was a problem hiding this comment.
Umm, this seems a regression, as we will want to support ECDS and non ECDSA keys
There was a problem hiding this comment.
Oh snaps, that must have been a bad rebase, Thanks for catching this!!!
There was a problem hiding this comment.
Fun fact, I wanted to take a crack at actually combining these and verify.go flag handling as they are identical (see the name of my branch LOL ), but then went off the rails and did this instead. But I'll try to get to it :)
hectorj2f
reviewed
Apr 12, 2022
| fi | ||
| echo '::endgroup::' | ||
|
|
||
| - name: Verify custom attestation with cosign, fails |
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
hectorj2f
approved these changes
Apr 12, 2022
dlorenc
approved these changes
Apr 12, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
) * Refactor policy related code, add support for vuln verify Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * Thanks @hectorj2f for catching a bad upstream rebase. Signed-off-by: Ville Aikas <vaikas@chainguard.dev> * Fix typo. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Ticket Link
Fixes
Release Note