Skip to content

Commit

Permalink
update cosign action to 1.5.1 (#53)
Browse files Browse the repository at this point in the history
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
  • Loading branch information
cpanato committed Jan 31, 2022
1 parent 47b6172 commit 51f8e5c
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -15,7 +15,7 @@ Add the following entry to your Github workflow YAML file:
```yaml
uses: sigstore/cosign-installer@main
with:
cosign-release: 'v1.4.1' # optional
cosign-release: 'v1.5.1' # optional
```

Example using a pinned version:
Expand All @@ -33,7 +33,7 @@ jobs:
- name: Install Cosign
uses: sigstore/cosign-installer@main
with:
cosign-release: 'v1.4.1'
cosign-release: 'v1.5.1'
- name: Check install!
run: cosign version
```
Expand Down
30 changes: 15 additions & 15 deletions action.yml
Expand Up @@ -10,7 +10,7 @@ inputs:
cosign-release:
description: 'cosign release version to be installed'
required: false
default: 'v1.5.0'
default: 'v1.5.1'
install-dir:
description: 'Where to install the cosign binary'
required: false
Expand All @@ -32,7 +32,7 @@ runs:
alias log_error="echo \"ERROR:\""
fi
set -e
mkdir -p ${{ inputs.install-dir }}
if [[ ${{ inputs.cosign-release }} == "main" ]]; then
Expand Down Expand Up @@ -61,13 +61,13 @@ runs:
esac
}
bootstrap_version='v1.5.0'
bootstrap_linux_amd64_sha='5bf1aa3ff4bd129c478e16e0b83febf3cc1b91b9daed60be31e8c6614a99b021'
bootstrap_linux_arm_sha='a06c932b9bcc0acce550603ced321f65484785d6d8d99aca344a59ed85d51647'
bootstrap_linux_arm64_sha='0027169db9929f22a6751255828b62d024526dd9821f64e4d94404ba7a225586'
bootstrap_darwin_amd64_sha='315fdddcfb3052f1b1b3f3f756bdcc05c8d740d8ac1e2cf57db38b1ada421a3b'
bootstrap_darwin_arm64_sha='5552e39f36e27241db0816f65bc37a9b141f4d973c42686da706a4d161cf81e1'
bootstrap_windows_amd64_sha='cdd2717287bf258ff8bfa51d938981d9ffd4eeb3341575f795634c0c41b556c4'
bootstrap_version='v1.5.1'
bootstrap_linux_amd64_sha='d1c9d4b5e21511c323c0dfa9123966e1d8b606ee5b939819f8785af8ff7d67b6'
bootstrap_linux_arm_sha='6f6cf3ca5c396152de6798b11f1febb3b8c87fd38c79b0dd2710794f63e00cc2'
bootstrap_linux_arm64_sha='8dd2f17f38a39b653e0880247dce6485204f6edfa2b6c2579cf1bfa1c7315a29'
bootstrap_darwin_amd64_sha='437219d97cf30543bd7522b87c57b37151368756196799aaa6bdca401b69386d'
bootstrap_darwin_arm64_sha='7425667fc587aae39bdc1347b669def4cf9659ee74e270cb8426f603ffeb42b1'
bootstrap_windows_amd64_sha='f8098071d1ae320fc2ee430e80df318e5f6e37c1a4717119c0589d573792e62c'
trap "popd >/dev/null" EXIT
Expand All @@ -86,7 +86,7 @@ runs:
desired_cosign_v060_signature='cosign_linux_amd64_0.6.0_linux_amd64.sig'
fi
;;
ARM)
bootstrap_filename='cosign-linux-arm'
bootstrap_sha=${bootstrap_linux_arm_sha}
Expand All @@ -96,7 +96,7 @@ runs:
exit 1
fi
;;
ARM64)
bootstrap_filename='cosign-linux-arm64'
bootstrap_sha=${bootstrap_linux_arm64_sha}
Expand All @@ -106,14 +106,14 @@ runs:
exit 1
fi
;;
*)
log_error "unsupported architecture $arch"
exit 1
;;
esac
;;
macOS)
case ${{ runner.arch }} in
X64)
Expand All @@ -126,7 +126,7 @@ runs:
desired_cosign_v060_signature='cosign_darwin_amd64_0.6.0_darwin_amd64.sig'
fi
;;
ARM64)
bootstrap_filename='cosign-darwin-arm64'
bootstrap_sha=${bootstrap_darwin_arm64_sha}
Expand All @@ -137,7 +137,7 @@ runs:
desired_cosign_v060_signature='cosign_darwin_arm64_0.6.0_darwin_arm64.sig'
fi
;;
*)
log_error "unsupported architecture $arch"
exit 1
Expand Down

3 comments on commit 51f8e5c

@jauderho
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the README be recommending the use of commit hashes for the action instead?

      - name: Install Cosign
        uses: sigstore/cosign-installer@main
        with:
          cosign-release: 'v1.5.1'

I'm not sure if Dependabot will know to do the right thing in the format above.

A version using commit hashes would look something like this instead:

      - name: Install Cosign
        uses: sigstore/cosign-installer@51f8e5c6fce54e46006ae97d73b2b6315f518752 # v1

@cpanato
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good @jauderho are you willing to open a PR to update this?

@jauderho
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that.

Please sign in to comment.