Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Goerli support #5770

Merged
merged 8 commits into from
May 27, 2024
Merged

Remove Goerli support #5770

merged 8 commits into from
May 27, 2024

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented May 13, 2024

Proposed Changes

Goerli is dead and deprecated. This PR removes Goerli support from Lighthouse. Flags like --network goerli and --network prater will no longer be accepted.

Additional Info

The validator manager test vectors have been regenerated for Holesky. This required some portability fixes to the generator script.

@michaelsproul michaelsproul added code-quality backwards-incompat Backwards-incompatible API change labels May 13, 2024
@michaelsproul michaelsproul added the ready-for-review The code is ready for review label May 14, 2024
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels May 21, 2024
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love deleting stuff 🎉 just a small comment above.

@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels May 27, 2024
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 27, 2024
@michaelsproul
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented May 27, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7f8b600

mergify bot added a commit that referenced this pull request May 27, 2024
@mergify mergify bot merged commit 7f8b600 into sigp:unstable May 27, 2024
27 of 29 checks passed
@michaelsproul michaelsproul deleted the rm-goerli branch May 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompat Backwards-incompatible API change code-quality ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants