refactor: reduce code duplication and remove unnecesary strings #5762
+8
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
if some other comments need to be removed then kindly tell |
chong-he
added
ready-for-review
dapplion
reviewed
May 11, 2024
| LightClientBootstrap(Arc<LightClientBootstrap<T>>), | ||
|
|
||
| /// A response to a get BLOBS_BY_ROOT request. | ||
| BlobsByRoot(Arc<BlobSidecar<T>>), | ||
|
|
There was a problem hiding this comment.
You can remove the whitespace too. Also ResponseTermination variant comments can be dropped too
| #[strum(serialize = "beacon_blocks_by_root")] | ||
| BlocksByRoot, | ||
| /// The `BlobsByRange` protocol name. | ||
|
|
There was a problem hiding this comment.
Drop the whitespaces for the enums your PR is already modifying
|
@chong-he all suggested changes have been addressed, can merge |
dapplion
approved these changes
May 22, 2024
|
Hi @1010adigupta However it looks like this was built on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
closes #5745
Proposed Changes
modifies code according to issue description, removes some boilerplate comments and reduces code duplication.