Log block import source #5738
Merged
Log block import source #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
example logs
|
dapplion
approved these changes
May 9, 2024
| @@ -3048,6 +3055,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> { | |||
| "Beacon block imported"; | |||
| "block_root" => ?block_root, | |||
| "block_slot" => block_slot, | |||
| "source" => block_source.to_string(), | |||
There was a problem hiding this comment.
You should able to do this if you implement display
"source" => %block_source,
Love this! |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 6636167 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #5721
Proposed Changes
Add a source tag to block import logs to indicate where the imported block came from. Options are Lookup, Gossip, RangeSync and HttpApi