Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop block data from BlockError and BlobError #5735

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from
Open

Drop block data from BlockError and BlobError #5735

wants to merge 3 commits into from

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented May 7, 2024 •
edited

Issue Addressed

BlockError::ParentUnknown has a full RpcBlock are argument. This arrangement is:

  • unnecessary: whenever BlockError::ParentUnknown is handled a block is already available
  • strange: requires implementing into_rpc_block which is a strange downgrade from types with strong meaning like MaybeAvailableBlock::Available

Proposed Changes

  • Drop block data from BlockError and BlobError
  • BlockError and a bunch of similar types are no longer generic
  • Drop into_rpc_block

@dapplion dapplion added the ready-for-review The code is ready for review label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dapplion