Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default target peers documentation #5727

Merged
merged 1 commit into from
May 23, 2024

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented May 6, 2024

Issue Addressed

The docs say the default target peers is 80 when its actually 100

Additional Info

I am not an airdrop farmer 😉

@eserilev eserilev changed the base branch from stable to unstable May 6, 2024 21:39
@eserilev eserilev added the docs Documentation label May 6, 2024
@michaelsproul
Copy link
Member

michaelsproul commented May 7, 2024

Not sure if mergify will let us merge without fixing the target branch check. Let's see.

@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented May 7, 2024

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • check-success=target-branch-check
      • #approved-reviews-by >= 1
      • check-success=license/cla
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success=Configuration changed

@michaelsproul
Copy link
Member

Ah yeah, looks like you need to amend the commit/rebase on unstable @eserilev

@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented May 7, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #5727 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label May 7, 2024
@michaelsproul
Copy link
Member

@Mergifyio refresh

Copy link

mergify bot commented May 7, 2024

refresh

✅ Pull request refreshed

@michaelsproul
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented May 7, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@michaelsproul
Copy link
Member

@Mergifyio queue

Copy link

mergify bot commented May 7, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request May 7, 2024
@michaelsproul
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented May 7, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented May 7, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request May 7, 2024
@michaelsproul
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented May 13, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented May 13, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request May 13, 2024
@jimmygchen
Copy link
Member

@mergify requeue

Copy link

mergify bot commented May 23, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented May 23, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 61b29fa

mergify bot added a commit that referenced this pull request May 23, 2024
mergify bot added a commit that referenced this pull request May 23, 2024
@mergify mergify bot merged commit 61b29fa into sigp:unstable May 23, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants