Electra: Remaining Consensus Data Structures #5712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update * experiment * superstruct changes * revert * superstruct changes * fix tests * indexed attestation * indexed attestation superstruct * updated TODOs
* `superstruct` Attester Fork Variants * Push a little further * Deal with Encode / Decode of AttesterSlashing * not so sure about this.. * Stop Encode/Decode Bounds from Propagating Out * Tons of Changes.. * More Conversions to AttestationRef * Add AsReference trait (#15) * Add AsReference trait * Fix some snafus * Got it Compiling! :D * Got Tests Building * Get beacon chain tests compiling --------- Co-authored-by: Michael Sproul <micsproul@gmail.com>
ethDreamer
added
work-in-progress
ethDreamer
commented
May 3, 2024
| | ForkName::Capella | ||
| | ForkName::Deneb => Self::Base(ssz_decode_file(path)?), | ||
| ForkName::Electra => Self::Electra(ssz_decode_file(path)?), | ||
| }) | ||
| } |
There was a problem hiding this comment.
something is strange here.. the EF attester_slashing tests pass even when I make this always decode Electra
ethDreamer
commented
May 3, 2024
| | ForkName::Altair | ||
| | ForkName::Bellatrix | ||
| | ForkName::Capella | ||
| | ForkName::Deneb => { |
There was a problem hiding this comment.
here too.. the EF tests pass even if i make this always decode electra..
* Upgrade `superstruct` to `0.8.0` * superstruct `AggregateAndProof`
Merge unstable into Electra attestation changes
* fix get attesting indices * better errors * fix compile * only get committee index once
* attestation related ef test fixes * delete commented out stuff
* Fix Aggregation Pool for Electra * Remove Outdated Interface
* fix get attesting indices (#5742) * fix get attesting indices * better errors * fix compile * only get committee index once * Ef test fixes (#5753) * attestation related ef test fixes * delete commented out stuff * Fix Aggregation Pool for Electra (#5754) * Fix Aggregation Pool for Electra * Remove Outdated Interface * fix ssz (#5755) --------- Co-authored-by: realbigsean <sean@sigmaprime.io>
This reverts commit ab9e58a.
…/lighthouse into electra_op_pool
* add compute_on_chain_agg impl to op pool changes * fmt * get op pool tests to pass
Optimise Electra op pool aggregation
* subscribe to the correct att subnets for electra * subscribe to the correct att subnets for electra
…merge_unstable Merge `unstable` into `electra_attestation_changes`
Fix validator logic
…g-handling Electra slashing handling
* Remove Crappy Decode impl for Attestation * Remove Inefficient Attestation Decode impl * Implement Schema Upgrade / Downgrade * Update beacon_node/beacon_chain/src/schema_change/migration_schema_v20.rs Co-authored-by: Michael Sproul <micsproul@gmail.com> --------- Co-authored-by: Michael Sproul <micsproul@gmail.com>
…5810) * - get attestation related beacon chain tests to pass - observed attestations are now keyed off of data + committee index - rename op pool attestationref to compactattestationref - remove unwraps in agg pool and use options instead - cherry pick some changes from ef-tests-electra * cargo fmt * fix failing test * Revert dockerfile changes * make committee_index return option * function args shouldnt be a ref to attestation ref * fmt * fix dup imports --------- Co-authored-by: realbigsean <seananderson33@GMAIL.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This PR implements the remaining consensus data structure changes in
Electra. It can't be merged until we cut a release for5.2.0