Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass vec to range sync batch #5710

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented May 3, 2024

Issue Addressed

Non-urgent clean-up possible after

This can wait for after v5.2.0

Currently we are:

  • Fetching an entire Vec of blocks in the network context
  • Constructing a stream with None terminator in sync manager
  • Batch handles each block individually

Proposed Changes

Instead, we can just pass the vec from the network context to the batch

All logic in unchanged, most of the diff is a change in indentation

@dapplion dapplion force-pushed the range-sync-pass-block-vec branch from e12d908 to 87cbe23 Compare May 3, 2024 13:51
@dapplion dapplion added the ready-for-review The code is ready for review label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants