[Merged by Bors] - Linkcheck fix #3452
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I think we need to change the lighthouse book for the linkcheck to run in CI.. but this worked for me locally |
realbigsean
added
ready-for-review
michaelsproul
approved these changes
Aug 11, 2022
|
The panic is here, this is from the gas limit API CI run |
|
The mdbook docker container uses chrono, was digging into it earlier. Sorry for the lack of description 😊 |
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
## Issue Addressed I think we're running into this in our linkcheck, so I'm going to frist verify linkcheck fails on the current version, and then try downgrading it to see if it passes chronotope/chrono#755 Co-authored-by: realbigsean <sean@sigmaprime.io>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
## Issue Addressed I think we're running into this in our linkcheck, so I'm going to frist verify linkcheck fails on the current version, and then try downgrading it to see if it passes chronotope/chrono#755 Co-authored-by: realbigsean <sean@sigmaprime.io>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed I think we're running into this in our linkcheck, so I'm going to frist verify linkcheck fails on the current version, and then try downgrading it to see if it passes chronotope/chrono#755 Co-authored-by: realbigsean <sean@sigmaprime.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
I think we're running into this in our linkcheck, so I'm going to frist verify linkcheck fails on the current version, and then try downgrading it to see if it passes chronotope/chrono#755