Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Upgrade dependencies #2513

Closed
wants to merge 2 commits into from
Closed

Conversation

michaelsproul
Copy link
Member

Proposed Changes

  • Consolidate Tokio versions: everything now uses the latest v1.10.0, no more tokio-compat.
  • Many semver-compatible changes via cargo update. Notably this upgrades from the yanked v0.8.0 version of crossbeam-deque which is present in v1.5.0-rc.0
  • Many semver incompatible upgrades via cargo upgrades and cargo upgrade --workspace pkg_name. Notable ommissions:
    • Prometheus, to be handled separately: Panic in Prometheus timer #2485
    • rand, rand_xorshift: the libsecp256k1 package requires 0.7.x, so we'll stick with that for now
    • ethereum-types is pinned at 0.11.0 because that's what web3 is using and it seems nice to have just a single version

Additional Info

We still have two versions of libp2p-core due to discv5 depending on the v0.29.0 release rather than master. AFAIK it should be OK to release in this state (cc @AgeManning )

@michaelsproul michaelsproul added ready-for-review The code is ready for review v1.5.0 For inclusion in v1.5.0 release labels Aug 14, 2021
@AgeManning
Copy link
Member

Yeah I agree I think its fine. There may be a discv5 update soon. I'll ensure to make sure discv5 targets latest libp2p releases. It will just be a matter of timing then.

@michaelsproul
Copy link
Member Author

bors r+

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 16, 2021
bors bot pushed a commit that referenced this pull request Aug 17, 2021
## Proposed Changes

* Consolidate Tokio versions: everything now uses the latest v1.10.0, no more `tokio-compat`.
* Many semver-compatible changes via `cargo update`. Notably this upgrades from the yanked v0.8.0 version of crossbeam-deque which is present in v1.5.0-rc.0
* Many semver incompatible upgrades via `cargo upgrades` and `cargo upgrade --workspace pkg_name`. Notable ommissions:
    - Prometheus, to be handled separately: #2485
    - `rand`, `rand_xorshift`: the libsecp256k1 package requires 0.7.x, so we'll stick with that for now
    - `ethereum-types` is pinned at 0.11.0 because that's what `web3` is using and it seems nice to have just a single version
    
## Additional Info

We still have two versions of `libp2p-core` due to `discv5` depending on the v0.29.0 release rather than `master`. AFAIK it should be OK to release in this state (cc @AgeManning )
@bors bors bot changed the title Upgrade dependencies [Merged by Bors] - Upgrade dependencies Aug 17, 2021
@bors bors bot closed this Aug 17, 2021
pawanjay176 pushed a commit to pawanjay176/lighthouse that referenced this pull request Aug 27, 2021
## Proposed Changes

* Consolidate Tokio versions: everything now uses the latest v1.10.0, no more `tokio-compat`.
* Many semver-compatible changes via `cargo update`. Notably this upgrades from the yanked v0.8.0 version of crossbeam-deque which is present in v1.5.0-rc.0
* Many semver incompatible upgrades via `cargo upgrades` and `cargo upgrade --workspace pkg_name`. Notable ommissions:
    - Prometheus, to be handled separately: sigp#2485
    - `rand`, `rand_xorshift`: the libsecp256k1 package requires 0.7.x, so we'll stick with that for now
    - `ethereum-types` is pinned at 0.11.0 because that's what `web3` is using and it seems nice to have just a single version
    
## Additional Info

We still have two versions of `libp2p-core` due to `discv5` depending on the v0.29.0 release rather than `master`. AFAIK it should be OK to release in this state (cc @AgeManning )
@michaelsproul michaelsproul deleted the dep-upgrades branch May 5, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v1.5.0 For inclusion in v1.5.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants