Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop some boilerplate in lighthouse_network #5745

Open
dapplion opened this issue May 9, 2024 · 0 comments · May be fixed by #5762
Open

Drop some boilerplate in lighthouse_network #5745

dapplion opened this issue May 9, 2024 · 0 comments · May be fixed by #5762
Labels
low-hanging-fruit Easy to resolve, get it before someone else does!

Comments

@dapplion
Copy link
Collaborator

dapplion commented May 9, 2024

Description

There are some comments that do not provide any new information and are just noise

lighthouse/beacon_node/lighthouse_network/src/rpc/methods.rs

Lines 434 to 441 in 3b42c8c

/// A response to a get BLOCKS_BY_ROOT request.
BlocksByRoot(Arc<SignedBeaconBlock<E>>),
/// A response to a get BLOBS_BY_RANGE request
BlobsByRange(Arc<BlobSidecar<E>>),
/// A response to a get LIGHT_CLIENT_BOOTSTRAP request.
LightClientBootstrap(Arc<LightClientBootstrap<E>>),

lighthouse/beacon_node/lighthouse_network/src/rpc/protocol.rs

Lines 235 to 239 in 3b42c8c

pub enum Protocol {
/// The Status protocol name.
Status,
/// The Goodbye protocol name.
Goodbye,

lighthouse/beacon_node/lighthouse_network/src/rpc/rate_limiter.rs

Lines 84 to 89 in 3b42c8c

/// Goodbye rate limiter.
goodbye_rl: Limiter<PeerId>,
/// Ping rate limiter.
ping_rl: Limiter<PeerId>,
/// MetaData rate limiter.
metadata_rl: Limiter<PeerId>,

lighthouse/beacon_node/lighthouse_network/src/service/api_types.rs

Lines 37 to 41 in 3b42c8c

pub enum Request {
/// A Status message.
Status(StatusMessage),
/// A blocks by range request.
BlocksByRange(BlocksByRangeRequest),

Matches like this could group conceptually protocol and use A | B | C => return

lighthouse/beacon_node/lighthouse_network/src/peer_manager/mod.rs

Lines 601 to 614 in 3b42c8c

ConnectionDirection::Outgoing => match protocol {
Protocol::Ping => PeerAction::LowToleranceError,
Protocol::BlocksByRange => PeerAction::MidToleranceError,
Protocol::BlocksByRoot => PeerAction::MidToleranceError,
Protocol::BlobsByRange => PeerAction::MidToleranceError,
Protocol::BlobsByRoot => PeerAction::MidToleranceError,
Protocol::DataColumnsByRoot => PeerAction::MidToleranceError,
Protocol::DataColumnsByRange => PeerAction::MidToleranceError,
Protocol::LightClientBootstrap => return,
Protocol::LightClientOptimisticUpdate => return,
Protocol::LightClientFinalityUpdate => return,
Protocol::Goodbye => return,
Protocol::MetaData => return,
Protocol::Status => return,

@dapplion dapplion added the low-hanging-fruit Easy to resolve, get it before someone else does! label May 9, 2024
@1010adigupta 1010adigupta linked a pull request May 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low-hanging-fruit Easy to resolve, get it before someone else does!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: reduce code duplication and remove unnecesary strings 1010adigupta/lighthouse
1 participant
@dapplion