Update dependencies #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
ackintosh
changed the title
AgeManning
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues to fix
1 . The
prometheus-client'sprotobuffeature has been released in v0.19.0, andrust-libp2phas updated its dependency to v0.19.0 in the master branch. Howeverprometheus-clientv0.19.0 has a bug in encoding labels.2 . The current version of testground's sdk-rust does not persist the logs. This is painful when we run test plans on EKS since we can not observe the logs.
Updated dependencies
prometheus-clientto fix/protobuf-labels branch which contains a fix for encoding labels. See protobuf: Fix label encoding prometheus/client_rust#123.libp2pto prometheus-client-0.20.0 branch which contains the fixed prometheus-client. See ackintosh/rust-libp2p@df09870.testgroundto 1fd032e, which contains a feature to outputrun.outthat is useful for use on EKS. See Write events to run.out testground/sdk-rust#45.Checklist