Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image from only taking PNG #285

Closed
wants to merge 1 commit into from

Conversation

myagmartseren
Copy link

No description provided.

@oneplus1000
Copy link
Collaborator

Thanks for the PR, but I think changing function parameters like this will cause compile errors in old code that uses gopdf. Maybe instead of fixing the old function, you add a new function, something like this.

func (gp *GoPdf) ImageFromWithOption(img image.Image, x float64, y float64, rect *Rect, option OptionForImageFrom) error  {
 ...
}

type OptionForImageFrom struct{
	Format string  // png,jpeg ...
	//... for future additions.
}

@myagmartseren
Copy link
Author

Oh good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants