Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling linters that were suppose to be enabled with --enable-all flag #231

Merged
merged 1 commit into from Dec 1, 2021

Conversation

jgheewala
Copy link
Contributor

No description provided.

@jgheewala jgheewala force-pushed the enable_golang_linters branch 6 times, most recently from d4d1875 to 44f154f Compare November 18, 2021 20:39
.golangci.yml Outdated Show resolved Hide resolved
disco/disco.go Outdated Show resolved Hide resolved
@jgheewala jgheewala force-pushed the enable_golang_linters branch 2 times, most recently from 2232ff5 to 8df96ef Compare November 19, 2021 16:10
fixing build breakage too by adding a bigger box & migrating testing on
go1.17.3
Copy link
Contributor

@keitwb keitwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jgheewala jgheewala merged commit ff8e29a into master Dec 1, 2021
@atoulme atoulme deleted the enable_golang_linters branch January 5, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants