Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade prost to 0.8 #335

Merged
merged 1 commit into from Jul 9, 2021
Merged

Upgrade prost to 0.8 #335

merged 1 commit into from Jul 9, 2021

Conversation

rubdos
Copy link
Contributor

@rubdos rubdos commented Jul 9, 2021

The dreaded tokio-rs/prost#154 (Prost Message vec![] + encode + expect) can now be get rid of in most places, thanks to tokio-rs/prost#378. In some places, I've left the .encode call because it's doing some prepending of magic bytes.

Copy link
Contributor

@jrose-signal jrose-signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting that into prost, nice cleanup!

@jrose-signal jrose-signal merged commit 8fc9361 into signalapp:master Jul 9, 2021
@rubdos rubdos deleted the prost08 branch July 22, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants