Skip to content

Commit

Permalink
add note on removing duplicated stack trace information
Browse files Browse the repository at this point in the history
  • Loading branch information
cosmicexplorer committed Oct 10, 2021
1 parent c364e31 commit de8d7f1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions rust/protocol/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ pub enum SignalProtocolError {
/// invalid state for call to {0} to succeed: {1}
InvalidState(&'static str, String),

// TODO: avoid duplicating error information in the Display impl and the #[from] or #[source]
// attribute if/when we switch to using an error reporting mechanism supporting stack traces:
// see https://github.com/yaahc/blog.rust-lang.org/blob/master/posts/inside-rust/2021-05-15-What-the-error-handling-project-group-is-working-towards.md#duplicate-information-issue
/// failed to decode protobuf: {0}
ProtobufDecodingError(#[from] prost::DecodeError),
/// failed to encode protobuf: {0}
Expand Down

0 comments on commit de8d7f1

Please sign in to comment.