Polish UX for sandbox commands

[enisoc]

• sandbox create: Add wait timeout and spinner.
• sandbox delete: Wait for sandbox to fully terminate.
• sandbox create: Print info on accessing the sandbox.
• sandbox get: Print details instead of a summary table.
• Add 'sandbox get-status' command.
• sandbox create/delete: Use new /status API.

[scott-cotton]

For delete, I am getting the attached image for the output, which is odd because it is
repeating the same (truncated) message but still has the spinner.

[enisoc]

I was able to reproduce that too by making my terminal window narrower. So it seems that the spinner library (yacspin) doesn't work properly when you try to print a message that doesn't fit in the terminal.

I don't see an issue for that library, but the other popular Go spinner library seems to have the same issue. It appears to be a common challenge for spinners, though potentially solvable.

As a quick workaround, perhaps we could truncate the message to fit in the terminal while the spinner is running, and then print the full message only at the end when the spinner stops.

[enisoc]

@scott-cotton I implemented the above workaround. PTAL.

[scott-cotton]

Regarding the print package, it seems to me that it is starting to scatter the consolidation of a command implementation under internal/command/

Would it be possible to have things like print.{ClusterTable, SandboxDetails} in its own file and function under internal/command/? In this scenario I would consider what's remaining in print to be minor helper functionality such as making the json more like the yaml, and it seems it would retain the nice property of the current organisation in this PR of breaking out individual cases when they start to become more cumbersome in the switch statement.

[scott-cotton]

@scott-cotton I implemented the above workaround. PTAL.

Looks like that will work, great. At the same time, I'd personally have preferred being more conservative about the packages we import, as often enough the dependencies + such workarounds end up taking more time in the long run than building directly what we need, starting with minimal features. A spinner seems like a it may be such a case.

[enisoc]

Regarding the print package, it seems to me that it is starting to scatter the consolidation of a command implementation under internal/command/

Good point. I moved the command-specific printers back into the same package as the rest of each command's implementation.

A spinner seems like a it may be such a case.

I thought so too so I started without a spinner at all and just trying to rewrite the status line. I started running into terminal nuances and at some point I decided it would be a better use of my time to just pick an off-the-shelf library because I don't know enough about this terminal magic.

[foxish]

LGTM aside from the one comment

[foxish]

seems like a weird error message - maybe we group this under "Waiting for sandbox to terminate"?

[enisoc]

Done.