Add raw to file names #8729
Draft
Add raw to file names #8729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcp images contain the word raw in the file names. This caused a error when following the online guide. Signed-off-by: Bob Henkel <bob.henkel@gmail.com>
frezbo
reviewed
May 13, 2024
| @@ -30,14 +30,14 @@ export REGION="us-central1" | |||
| ### Create the Image | |||
|
|
|||
| First, download the Google Cloud image from a Talos [release](https://github.com/siderolabs/talos/releases). | |||
| These images are called `gcp-$ARCH.tar.gz`. | |||
| These images are called `gcp-$ARCH.raw.tar.gz`. | |||
There was a problem hiding this comment.
@smira are these raw still or .zst?
There was a problem hiding this comment.
Still .raw (this is disk image suffix), e.g. https://github.com/siderolabs/talos/releases/tag/v1.8.0-alpha.0
GCP natively supports .tar.gz iirc, so we generate that by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcp images contain the word raw in the file names. This caused a error when following the online guide.
Pull Request
What? (description)
Online docs reference gcp-amd64.tar.gz but the actual final name is gcp-amd64.raw.tar.gz
Why? (reasoning)
When I followed the instructions they failed because of this file name issue.
Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)