Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable forwardKubeDNSToHost by default #8717

Merged
merged 1 commit into from
May 23, 2024

Conversation

DmitriyMV
Copy link
Member

@DmitriyMV DmitriyMV commented May 7, 2024

And ensure that it works.

@smira
Copy link
Member

smira commented May 15, 2024

This should be a feat: as it's user-visible change, it should be listed in hack/release.toml notes, and let's clear it out of the other PR bits. So this PR will stay in v1.8, and the fix will be backported to v1.7

@DmitriyMV
Copy link
Member Author

/promote integration-cilium

@DmitriyMV
Copy link
Member Author

/promote integration-misc

And ensure that it works.

Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
@DmitriyMV DmitriyMV changed the title chore: enable forwardKubeDNSToHost by default feat: enable forwardKubeDNSToHost by default May 23, 2024
@DmitriyMV
Copy link
Member Author

@smira

This should be a feat:

Done.

it should be listed in hack/release.toml notes

Done.

and let's clear it out of the other PR bits. So this PR will stay in v1.8, and the fix will be backported to v1.7

Also done.

@DmitriyMV
Copy link
Member Author

/m

@talos-bot talos-bot merged commit fcd65ff into siderolabs:main May 23, 2024
43 checks passed
@DmitriyMV DmitriyMV deleted the forward branch May 23, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants