fix: downgrade Azure IMDS required version #8578
Merged
+74
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
fix/azure-stack-hub
branch
from
6fe213c
to
e7a88e1
Compare
|
/promote e2e-azure |
|
This seems to break Azure 😨 |
smira
force-pushed
the
fix/azure-stack-hub
branch
from
e7a88e1
to
a3a3301
Compare
smira
force-pushed
the
fix/azure-stack-hub
branch
from
a3a3301
to
a3e3d68
Compare
seems to work fine on Azure (proper) |
DmitriyMV
approved these changes
May 31, 2024
smira
force-pushed
the
fix/azure-stack-hub
branch
2 times, most recently
from
f3781e9
to
bfbbed5
Compare
|
/m |
Fixes siderolabs#8555 It seems that older version supports same set of fields we actually use in our platform code, so we can safely downgrade to the version supported by Azure Stack Hub. I used [this repo](https://github.com/Azure/azure-rest-api-specs/tree/main/specification/imds/data-plane/Microsoft.InstanceMetadataService/stable) to check schemas across versions. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/azure-stack-hub
branch
from
bfbbed5
to
9a23d84
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8555
It seems that older version supports same set of fields we actually use in our platform code, so we can safely downgrade to the version supported by Azure Stack Hub.
I used
this repo to check schemas across versions.