fix: cancel all operations if c.V1Alpha2().Run fails.
#8256
Conversation
DmitriyMV
force-pushed
the
fix-controller-fail
branch
3 times, most recently
from
2036645
to
b035f5b
Compare
DmitriyMV
force-pushed
the
fix-controller-fail
branch
2 times, most recently
from
1f97be3
to
766b06f
Compare
| defer system.Services(c.Runtime()).Shutdown(ctx) | ||
| s := system.Services(c.Runtime()) | ||
| defer func() { | ||
| shutdownCtx, shutdownCtxCancel := context.WithTimeout(context.Background(), time.Minute) |
There was a problem hiding this comment.
This is required, because when we cancel the context, Shutdown(context) sequence below will never run properly.
DmitriyMV
force-pushed
the
fix-controller-fail
branch
from
766b06f
to
fc20d4e
Compare
DmitriyMV
force-pushed
the
fix-controller-fail
branch
from
fc20d4e
to
682edee
Compare
|
we should rather fix the indefinite wait if we want to, but this place requires too much testing to get it right in all cases |
@smira are there any valid scenarios where running of sequencer should continue if the runtime failed? |
While we decide what to do with siderolabs#8263 and siderolabs#8256 this quickfix at least allows us to see what went wrong Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
probably not, but runtime failing correctly stops Talos except for the initialize sequence |
While we decide what to do with siderolabs#8263 and siderolabs#8256 this quickfix at least allows us to see what went wrong Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
The current code contains a deadlock if `c.V1Alpha2().Run` fails with an error because `EnforceKSPPRequirements` will indefinitely wait for a condition to happen, but the controller runtime is not running. This commit addresses this by replacing the error channel with `context.WithCancelCause` and canceling the context if the controller runner fails. Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DmitriyMV
force-pushed
the
fix-controller-fail
branch
from
682edee
to
b4b6afc
Compare
The current code contains a deadlock if
c.V1Alpha2().Runfails with an error becauseEnforceKSPPRequirementswill indefinitely wait for a condition to happen, but the controller runtime is not running. This commit addresses this by replacing the error channel withcontext.WithCancelCauseand canceling the context if the controller runner fails.