Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidekiq 7.0 changes #5080

Merged
merged 126 commits into from Oct 4, 2022
Merged

Sidekiq 7.0 changes #5080

merged 126 commits into from Oct 4, 2022

Conversation

mperham
Copy link
Collaborator

@mperham mperham commented Dec 6, 2021 •
edited

This branch holds all pending Sidekiq 7.0 changes. There is no timeline and we are still months away from release. Assume Summer 2022.

bf4
bf4 reviewed Jan 21, 2022
View reviewed changes
lib/sidekiq.rb Show resolved Hide resolved
adamniedzielski
adamniedzielski reviewed Apr 8, 2022
View reviewed changes
Gemfile.lock Outdated Show resolved Hide resolved
mperham and others added 26 commits May 10, 2022 14:20
@mperham
Remove delayed extensions in 7.0, fixes #5076
8aa48ec
@mperham
Bump our basic dependencies
6c7d40b
@mperham
More helpful output
43e0354
@mperham
Remove Ruby 2.5 and 2.6
18a36af
@mperham
Skip the buggy 4.5.0 release
20debc3
@mperham
Bump everything for Ruby 3.1 support
6fb839a
@mperham
Remove support for old, uncompressed backtrace fmt
813b8cf
@mperham
Update standard to use ruby 2.7 rules
890c75b
@mperham
remove unused method
5c37abb
@mperham
Move old upgrade notes into docs/
aabac7c
@mperham
Require Redis 6.0
3a0f721
@mperham
Not really a thing
a093a22
@mperham
7.0 notes, fix CI
2a06095
@samrjenkins @mperham
Add yalphabetize for yaml normalisation (#5199)
9f9310d 
* add yalphabetize for locale normalisation

* normalise locales

* replace comments
@mperham
Show locale and link to language files
a44d176
@mperham
Fix API change
f3cb019
@adamniedzielski @mperham
Run CI for PRs that target 7-0 (#5258)
901f381
@adamniedzielski @mperham
Rename lib/sidekiq/job.rb file
2fb87a8
@adamniedzielski @mperham
Rename lib/sidekiq/worker.rb to lib/sidekiq/job.rb
b17ac3e
@adamniedzielski @mperham
Swap Sidekiq::Worker and Sidekiq::Job
cea11b5
@adamniedzielski @mperham
Remove test/test_job.rb
6689399
@adamniedzielski @mperham
Rename test/test_worker.rb to test/test_job.rb
207ab43
@adamniedzielski @mperham
Test Sidekiq::Job instead of Sidekiq::Worker
6c2eb73
@mperham
Add new business code of conduct
43bb0a7
@mperham
yalp'ize again
4e7e060
@mperham
remove dupe dep
470657b
mperham and others added 22 commits September 20, 2022 14:09
@mperham
bump, release
eb85755
@mperham
Adjust CurrentAttributes to use String, fixes #5536
d0e0e54
@mperham
beta
7334692
@mperham
polish
14153c6
@mperham
Minimize metrics overhead, disable hourly/daily aggregates for now si…
354f368 
…nce we dont use them, expire histograms quicker
@adamlogic
render a "cursor" that follows the tooltip (#5530)
e5f93c7 
* WIP - trying to render a "cursor" that follows the tooltip

This is not yet working.

The intention is to have a vertical line on the chart corresponding to the currently shown "tooltip" info in the legend below the chart. This is the behavior of Sidekiq 6.

* Fix the chart cursor

* Move chart legend to the right

* Avoid content jumping when values change
@mperham
Add deploy mark uniqueness
0039b84
@mperham
polish
89d00fb
@mperham
A bold new look for CLI
3133d13
@mperham
Use config's default concurrency
4d1be2a
@mperham
polish banner
3a5c8ad
@cafedomancer @mperham
Add missing translations for ja
297e1d4
@JuanitoFatas @mperham
Add missing and improve existing translations for zh locales (#5533)
cc3ef98
@mperham
Be a little more conservative in cp version
9a54abc
@mperham
latest changes
6df3c01
@mperham
merge main
db31e23
@mperham
beta install message
c372d7f
@mperham
Fix license filename
9a98b7e
@mperham
oops
f50e9d3
@mperham
fix wiki links
707e18c
@mperham
remove 6.x deprecations
f632b46
@BobbyMcWho
Add ability to parse capsules from a config file (#5547)
26fed38
@BobbyMcWho BobbyMcWho mentioned this pull request Sep 29, 2022
Closed
amnindersingh12 and others added 4 commits September 30, 2022 06:23
@amnindersingh12
Minor grammatical changes (#5551)
3d89185 
While going through the 7.0-Upgrade file, I noticed a grammatical error, so I used Grammarly and LanguageTool to double-check the content. I made a few minor changes to the 7.0-Upgrade file based on Grammarly's suggestions.
@mperham
remove unused module
1db4e1d
@mperham
Remove unused parameter in Fetch/bulk_requeue API
f466a03
@mperham
Merge main, adjust WorkSet#each to not greed parse job_hash JSON
ad9442f
@mperham mperham merged commit ad9442f into main Oct 4, 2022
@mperham mperham deleted the 7-0 branch October 4, 2022 15:47
@dilraj-vidyard
Copy link

Amazing job @mperham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bf4 bf4 bf4 left review comments

@nateberkopec nateberkopec nateberkopec left review comments

@adamniedzielski adamniedzielski adamniedzielski left review comments

@dilraj-vidyard dilraj-vidyard dilraj-vidyard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet