Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize process count in Poller #4882

Closed
wants to merge 1 commit into from
Closed

Memoize process count in Poller #4882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/sidekiq/scheduled.rb
View file
Open in desktop
Expand Up @@ -117,7 +117,10 @@ def random_poll_interval
# As we run more processes, the scheduling interval average will approach an even spread
# between 0 and poll interval so we don't need this artifical boost.
#
if process_count < 10
# Memoize the process count to avoid calling SCARD/HGET on all the processes everytime #wait is called
# since there may be a lot of processes online.
@process_count ||= process_count
if @process_count < 10
# For small clusters, calculate a random interval that is ±50% the desired average.
poll_interval_average * rand + poll_interval_average.to_f / 2
else
Expand Down