Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect button rounding #4862

Merged
merged 1 commit into from Apr 7, 2021

Commits on Apr 7, 2021

  1. Fix incorrect button rounding

    .btn-group uses :first-child and :last-child to determine which
    buttons should have rounded corners and which ones should have
    square corners. The "Quiet" button had a square left corner,
    because the first child was a CSRF hidden field tag.
    
    Keeping only .btn elements inside the .btn-group means that the
    1 or 2 buttons are rounded as expected. When there's no "Quiet"
    button, the "Stop" button has 4 round corners. When both buttons
    are present, the corners between the buttons are square.
    
    Fixes sidekiq#4858
    natematykiewicz committed Apr 7, 2021
    Copy the full SHA
    3e4d0c7 View commit details
    Browse the repository at this point in the history