Change the background colour for the RSS info badge to be less eye-catching #4819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching
The red badge beside the RSS column header in the processes table is quite
eye-catching. The bold red colour might be appropriate for a notification
badge indicating that the user needs to do something, but, for a "more info"
badge, something that stands out less from
the background is nicer.
|
This is really well done, I'll pull this into an element in Sidekiq Enterprise too which uses an info-circle too. #4806 needs some CSS polish too if I could ask for your help. I'll merge it and you can run master with |
|
That should be:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3b5ae30 added a process RSS column to the table on the busy page. The red badge beside column header is useful for linking users to more information, but it's quite eye-catching. Since the badge doesn't indicate a notification or status change, it would be nice if it stood out a little less from the background.
This PR changes the background colour to light grey in normal mode and dark grey in dark mode. I also changed the class name from "circled" to "info-circle" since, with the more discreet colouring, I feel like it's less generally useful.
Before:
After:
