Commits on Apr 18, 2020

1. Remove SSL parameters from Redis connection logging to avoid exception …

   In 3f9c4bf the Redis connection options began to be cloned (via dumping
   and re-marshalling) to avoid issues with password redaction in logging
   altering the connection options and breaking authentication with Sentinels.
   
   Unfortunately, this change caused an exception on boot for users of
   Redis over SSL. The `OpenSSL::X509::Store` object used for SSL certs is
   not yet dumpable in the bundled OpenSSL wrapper for current Rubies
   (although it does in master as of ruby/openssl#281).
   
   The fix here prunes the `ssl_params` options out of the Redis
   configuration options before the dumping and marshalling. It's probably
   better not to include those in logging anyway for privacy purposes.
   
   Fix #4531

   

   geoffharcourt committed Apr 18, 2020
   Copy the full SHA

   27b6b76 View commit details

   Browse the repository at this point in the history