Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not connect to redis at exit if not needed #4502

Merged
merged 1 commit into from Mar 23, 2020
Merged

Do not connect to redis at exit if not needed #4502

merged 1 commit into from Mar 23, 2020

Commits on Mar 23, 2020

  1. Do not connect to redis at exit if not needed 

    A fix for sidekiq#4498 introduced
a call-back that is executed at ruby VM exit and tries to connect to redis.

This call-back is also executed in CI runs and in all other cases where sidekiq is loaded but not used with real redis.

As a work-around, keep the at_exit hook but communicate to redis only if there is something to send, i.e. the number of processed or failed jobs is greater than zero
    Mikhail Doronin committed Mar 23, 2020
    Copy the full SHA
    b2b7399 View commit details
    Browse the repository at this point in the history