Remove connection naming, fixes #4479

Changes.md

@@ -2,6 +2,11 @@
 
 [Sidekiq Changes](https://github.com/mperham/sidekiq/blob/master/Changes.md) | [Sidekiq Pro Changes](https://github.com/mperham/sidekiq/blob/master/Pro-Changes.md) | [Sidekiq Enterprise Changes](https://github.com/mperham/sidekiq/blob/master/Ent-Changes.md)
 
+HEAD
+---------
+
+- Remove Redis connection naming [#4479]
+
 6.0.6
 ---------
 

lib/sidekiq/redis_connection.rb

@@ -12,7 +12,6 @@ def create(options = {})
           options[key.to_sym] = options.delete(key)
         end
 
-        options[:id] = "Sidekiq-#{Sidekiq.server? ? "server" : "client"}-PID-#{::Process.pid}" unless options.key?(:id)
         options[:url] ||= determine_redis_provider
 
         size = if options[:size]

test/test_redis_connection.rb

@@ -27,7 +27,6 @@ def client_for(redis)
     it "creates a pooled redis connection" do
       pool = Sidekiq::RedisConnection.create
       assert_equal Redis, pool.checkout.class
-      assert_equal "Sidekiq-server-PID-#{$$}", pool.checkout.connection.fetch(:id)
     end
 
     # Readers for these ivars should be available in the next release of
@@ -207,7 +206,7 @@ def server_connection(*args)
         assert_includes(output, ':host=>"host1", :port=>26379, :password=>"REDACTED"')
         assert_includes(output, ':host=>"host2", :port=>26379, :password=>"REDACTED"')
         assert_includes(output, ':host=>"host3", :port=>26379, :password=>"REDACTED"')
-        assert_includes(output, ':password=>"REDACTED", :id=>')
+        assert_includes(output, ':password=>"REDACTED"')
       end
     end
   end