Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Sidekiq::Job #457

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jrmhaig
Copy link
Contributor

@jrmhaig jrmhaig commented Nov 27, 2023

Sidekiq::Worker has been renamed as Sidekiq::Job. See;

This PR adds a note to the README file to reflect this. The example still uses the old, deprecated version as this will reliably work with all supported versions of Sidekiq.

Fixes #456

Sidekiq::Worker has been renamed as Sidekiq::Job. See;

* Sidekiq::Job added as an alias in v6.3: https://github.com/sidekiq/sidekiq/blob/main/Changes.md#630
* Sidekiq::Worker replaced with Sidekiq::Job and Sidekiq::Worker retained as an alias in v6.4: https://github.com/sidekiq/sidekiq/blob/main/Changes.md#640
@marcelolx marcelolx merged commit ab177fb into sidekiq-scheduler:master Nov 28, 2023
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend Sidekiq::Job instead of Sidekiq::Worker
2 participants