Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata for Sidekiq strict_args! #403

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

craigmcn
Copy link
Contributor

@craigmcn craigmcn commented Aug 23, 2022

- update `scheduled_at` metadata to string key, hash rocket syntax
- update spec to expect string key, hash rocket syntax
Copy link
Member

@marcelolx marcelolx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @craigmcn!

@yeonhoyoon
Copy link

This could potentially be a breaking change for some applications, if scheduled_at was being accessed by symbol key.
It might have been a better idea to put this into a minor version, not patch version.

For people visiting this issue after updating the gem to 4.0.3:
metadata[:scheduled_at] should be changed to metadata["scheduled_at"]

@marcelolx
Copy link
Member

@yeonhoyoon could you give an example of why you're accessing the scheduled_at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants